[lkml]   [2019]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH 4.14 11/92] ALSA: opl3: fix mismatch between snd_opl3_drum_switch definition and declaration
    [ Upstream commit b4748e7ab731e436cf5db4786358ada5dd2db6dd ]

    The function snd_opl3_drum_switch declaration in the header file
    has the order of the two arguments on_off and vel swapped when
    compared to the definition arguments of vel and on_off. Fix this
    by swapping them around to match the definition.

    This error predates the git history, so no idea when this error
    was introduced.

    Signed-off-by: Colin Ian King <>
    Signed-off-by: Takashi Iwai <>
    Signed-off-by: Sasha Levin <>
    sound/drivers/opl3/opl3_voice.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/sound/drivers/opl3/opl3_voice.h b/sound/drivers/opl3/opl3_voice.h
    index eaef435e0528..abf6c23a721c 100644
    --- a/sound/drivers/opl3/opl3_voice.h
    +++ b/sound/drivers/opl3/opl3_voice.h
    @@ -41,7 +41,7 @@ void snd_opl3_timer_func(unsigned long data);

    /* Prototypes for opl3_drums.c */
    void snd_opl3_load_drums(struct snd_opl3 *opl3);
    -void snd_opl3_drum_switch(struct snd_opl3 *opl3, int note, int on_off, int vel, struct snd_midi_channel *chan);
    +void snd_opl3_drum_switch(struct snd_opl3 *opl3, int note, int vel, int on_off, struct snd_midi_channel *chan);

    /* Prototypes for opl3_oss.c */

     \ /
      Last update: 2019-04-18 20:29    [W:2.443 / U:0.184 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site