lkml.org 
[lkml]   [2019]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4] tty: rocket: Remove the rp_ioctl
From
Date
On 17. 04. 19, 8:46, Greg Kroah-Hartman wrote:
> On Wed, Apr 17, 2019 at 08:27:41AM +0200, Jiri Slaby wrote:
>> On 16. 04. 19, 16:53, Fuqian Huang wrote:
>>> --- a/drivers/tty/rocket.c
>>> +++ b/drivers/tty/rocket.c
>> ...
>>> -/* IOCTL call handler into the driver */
>>> -static int rp_ioctl(struct tty_struct *tty,
>>> - unsigned int cmd, unsigned long arg)
>>> -{
>>> - struct r_port *info = tty->driver_data;
>>> - void __user *argp = (void __user *)arg;
>>> - int ret = 0;
>>> -
>>> - if (cmd != RCKP_GET_PORTS && rocket_paranoia_check(info, "rp_ioctl"))
>>> - return -ENXIO;
>>> -
>>> - switch (cmd) {
>>> - case RCKP_GET_STRUCT:
>>> - if (copy_to_user(argp, info, sizeof (struct r_port)))
>>> - ret = -EFAULT;
>>> - break;
>>
>> I am not sure what Greg meant, but I had only this particular ioctl on
>> mind when I was writing about removal. The other ones might be used _in
>> theory_. Even though they are not exposed to userspace either. So if
>> they are not source of potential issues, I would keep them:
>
> I was just meaning that one specific ioctl, not the whole thing.
>
> Although dropping all of these custom ioctls is probably the right thing
> to do in the long-run, for now, let's just get rid of the problem one.

So could you rework the patch to remove only the one? And in a separate
patch, introduce a printk_ratelimited warning to every "case *:" (i.e.
no warning in the "default" case) in rp_ioctl about depreciation of the
ioctl?

thanks,
--
js
suse labs

\
 
 \ /
  Last update: 2019-04-17 08:53    [W:0.094 / U:1.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site