[lkml]   [2019]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH V1 3/3] regulator: slg51000: add slg51000 regulator driver
On Wed, Apr 17, 2019 at 11:25:29AM +0000, Eric Hyeung Dong Jeong wrote:
> On Wednesday, April 17, 2019 12:25 AM +0900, Mark Brown wrote:

> > This looks like it should be a get_status() operation as it's reading
> > status bits rather than the command we sent to the device - for that
> > just use regulator_is_enabled_regmap().

> I thought that it needs to return current status of a regulator when the function is called.
> I am wondering that the *is_enabled()* function is just to check
> If a regulator has been turned on or not rather than getting current status of the regulator.

It should say if we told the hardware to enable the regulator so the
former - basically, is the hardware in the same state it'd be in after
we called _enable() or _disable(). If there's a fault then that should
only affect is_enabled() if it resets the enable bit that _enable() set.
[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2019-04-17 17:51    [W:0.181 / U:14.608 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site