[lkml]   [2019]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v4 2/3] dt-bindings: backlight: add lm3630a bindings
On Wed, Apr 17, 2019 at 08:34:33AM -0500, Rob Herring wrote:
> On Tue, Apr 16, 2019 at 6:54 PM Brian Masney <> wrote:
> >
> > Add new backlight bindings for the TI LM3630A dual-string white LED.
> >
> > Signed-off-by: Brian Masney <>
> > ---
> > Rob: Since the common bindings aren't converted to the new JSON schema
> > yet, I'm not sure how to do led-sources here. I would expect that we'd
> > have the uint32-array on the common binding once it exists. I had to
> > add it here to keep 'make dt_binding_check' happy. I left the
> > description off though for that property since that'll come from common
> > once its converted.
> What was the error? '$ref' shouldn't be needed for this. The tooling
> has no knowledge whether there's common schema or not. So you probably
> have some pattern the meta-schema doesn't like and we need to fix.

Ahh, you're right... it works without the $ref. I just needed the
minItems and maxItems to fix the error I originally saw.

I'll wait for feedback from Dan before I send out another version with
your changes.



 \ /
  Last update: 2019-04-17 17:11    [W:0.049 / U:1.692 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site