[lkml]   [2019]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: Need advice about do we need this if condition
On Wed, Apr 17, 2019 at 2:59 AM Valdis Klētnieks
<> wrote:
> On Wed, 17 Apr 2019 08:25:22 +0300
> (Adding Al Viro and the linux-fsdevel lists, as at the very least, the manpage
> for the syscall needs some clarification...)
> > hello I am trying to fix
> So - convince us that it's in fact a "bug" and not a restriction.
> > I found cause
> > not
> > sure is it correct to remove such condition ?
> Does the CIFS protocol support copying from a file to another location in the
> same file? Was it intended to work on *any* filesystem?

Looks like it should be allowed on the same file as long as the source
and target file ranges do not overlap

section and 2.3.8
Server returns STATUS_NOT_SUPPORTED if "The source and target
destination ranges overlap on the same file."

and line 112 and following of smb2_ioctl_filesys.c in Samba code;a=blob;f=source3/smbd/smb2_ioctl_filesys.c;h=8a9c8c64ec9ddbca4623251555f4792d76aa6e44;hb=refs/heads/master#l112

> (For that matter, the manpage for the syscall is unclear on whether having both
> file descriptors open on the same file is OK or not - for bonus ambiguity
> points, there's exactly zero discussion of what happens if source and
> destination overlap destructively).



 \ /
  Last update: 2019-04-17 15:32    [W:0.033 / U:0.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site