lkml.org 
[lkml]   [2019]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v7 09/10] vsprintf: Avoid confusion between invalid address and value
    Date
    We are able to detect invalid values handled by %p[iI] printk specifier.
    The current error message is "invalid address". It might cause confusion
    against "(efault)" reported by the generic valid_pointer_address() check.

    Let's unify the style and use the more appropriate error code description
    "(einval)".

    Signed-off-by: Petr Mladek <pmladek@suse.com>
    ---
    Documentation/core-api/printk-formats.rst | 1 +
    lib/vsprintf.c | 2 +-
    2 files changed, 2 insertions(+), 1 deletion(-)

    diff --git a/Documentation/core-api/printk-formats.rst b/Documentation/core-api/printk-formats.rst
    index b2cac8d76b66..75d2bbe9813f 100644
    --- a/Documentation/core-api/printk-formats.rst
    +++ b/Documentation/core-api/printk-formats.rst
    @@ -64,6 +64,7 @@ of printing the address itself. In this case, the following error messages

    (null) data on plain NULL address
    (efault) data on invalid address
    + (einval) invalid data on a valid address

    Plain Pointers
    --------------
    diff --git a/lib/vsprintf.c b/lib/vsprintf.c
    index b989f1e8f35b..4e5666035b74 100644
    --- a/lib/vsprintf.c
    +++ b/lib/vsprintf.c
    @@ -1511,7 +1511,7 @@ char *ip_addr_string(char *buf, char *end, const void *ptr,
    case AF_INET6:
    return ip6_addr_string_sa(buf, end, &sa->v6, spec, fmt);
    default:
    - return string_nocheck(buf, end, "(invalid address)", spec);
    + return string_nocheck(buf, end, "(einval)", spec);
    }}
    }

    --
    2.16.4
    \
     
     \ /
      Last update: 2019-04-17 13:55    [W:3.023 / U:0.284 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site