lkml.org 
[lkml]   [2019]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH v7 00/10] vsprintf: Prevent silent crashes and consolidate error handling
Date
Crash in vsprintf() might be silent when it happens under logbuf_lock
in vprintk_emit(). This patch set prevents most of the crashes by probing
the address. The check is done only by %s and some %p* specifiers that need
to dereference the address.

Only the first byte of the address is checked to keep it simple. It should
be enough to catch most problems.

The check is explicitly done in each function that does the dereference.
It helps to avoid the questionable strchr() of affected specifiers. This
change motivated me to do some preparation patches that consolidated
the error handling and cleaned the code a bit.


Changes against v6:

+ Removed refactoring of the test_printf code [Andy]
+ Added missing check_pointer() in device_node_string()
+ Hard limit on the length of the inlined error msg [Sergey]

Changes against v5:

+ Rebased on top of current Linus' tree
+ Removed already included patch adding const qualifier
to ptr_to_id()
+ Removed controversial patch adding WARN() on invalid pointers
[Rasmus, Sergey, Andy]
+ Reshuffled changes to do all refactoring first.
+ Added handling also for the new %pt* modifiers
+ Use better descriptive function names [Andy]:
+ valid_string() -> string_nocheck()
+ valid_pointer_access() -> check_pointer()
+ check_pointer_access() -> check_pointer_msg()
+ Fixed typo and formatting [Andy]

Changes against v4:

+ rebased on top of
git://git.kernel.org/pub/scm/linux/kernel/git/pmladek/printk.git for-4.18
+ Added missing conts into ptr_to_ind() in a separate patch
+ Renamed __string to valid_string()
+ Avoid WARN() for invalid poimter specifiers
+ Removed noinline_for_stack where it was not really useful
+ WARN() when accessing invalid non-NULL address

Changes against v3:

+ Add valid_pointer_access() to do the check and store the error
message in one call.
+ Remove strchr(). Instead, validate the address in functions
that dereference the address.
+ Use probe_kernel_address() instead of probe_kernel_real().
+ Do the check only for unknown address.
+ Consolidate handling of unsupported pointer modifiers.

Changes against v2:

+ Fix handling with strchr(string, '\0'). Happens with
%p at the very end of the string.
+ Even more clear commit message
+ Documentation/core-api/printk-formats.rst update.
+ Add check into lib/test_printf.c.

Changes against v1:

+ Do not check access for plain %p.
+ More clear commit message.


Petr Mladek (10):
vsprintf: Shuffle restricted_pointer()
vsprintf: Consistent %pK handling for kptr_restrict == 0
vsprintf: Do not check address of well-known strings
vsprintf: Factor out %p[iI] handler as ip_addr_string()
vsprintf: Factor out %pV handler as va_format()
vsprintf: Factor out %pO handler as kobject_string()
vsprintf: Consolidate handling of unknown pointer specifiers
vsprintf: Prevent crash when dereferencing invalid pointers
vsprintf: Avoid confusion between invalid address and value
vsprintf: Limit the length of inlined error messages

Documentation/core-api/printk-formats.rst | 8 +
lib/test_printf.c | 25 +-
lib/vsprintf.c | 426 +++++++++++++++++++-----------
3 files changed, 298 insertions(+), 161 deletions(-)

--
2.16.4

\
 
 \ /
  Last update: 2019-04-17 13:54    [W:0.151 / U:0.912 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site