lkml.org 
[lkml]   [2019]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v1 2/3] MIPS: ath79: ar9331: add Ethernet nodes
From
Date
Hello!

On 17.04.2019 9:22, Oleksij Rempel wrote:

> Add ethernet nodes supported by ag71xx driver.
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
> arch/mips/boot/dts/qca/ar9331.dtsi | 25 ++++++++++++++++++++
> arch/mips/boot/dts/qca/ar9331_dpt_module.dts | 8 +++++++
> 2 files changed, 33 insertions(+)
>
> diff --git a/arch/mips/boot/dts/qca/ar9331.dtsi b/arch/mips/boot/dts/qca/ar9331.dtsi
> index 2bae201aa365..7d59c7c66dda 100644
> --- a/arch/mips/boot/dts/qca/ar9331.dtsi
> +++ b/arch/mips/boot/dts/qca/ar9331.dtsi
> @@ -116,6 +116,31 @@
> };
> };
>
> + eth0: eth@19000000 {

The name should be "ethernet@...> according to the DT spec.

> + status = "disabled";

Mmm, this one is typically specified last in the node.

> +
> + compatible = "qca,ar9330-eth";
> + reg = <0x19000000 0x200>;
> + interrupts = <4>;
> +
> + resets = <&rst 9>;
> + reset-names = "mac";
> + };
> +
> + eth1: eth@1a000000 {

"ethernet@..." again.

> + status = "disabled";
> +
> + compatible = "qca,ar9330-eth";
> + reg = <0x1a000000 0x200>;
> + interrupts = <5>;
> +
> + resets = <&rst 13>, <&rst 23>;
> + reset-names = "mac", "mdio";
> +
> + clocks = <&pll ATH79_CLK_MDIO>;
> + clock-names = "mdio";
> + };
> +
> usb: usb@1b000100 {
> compatible = "chipidea,usb2";
> reg = <0x1b000000 0x200>;
[...]

MBR, Sergei

\
 
 \ /
  Last update: 2019-04-17 10:51    [W:0.080 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site