lkml.org 
[lkml]   [2019]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 06/16] watchdog: hpwdt: drop warning after calling watchdog_init_timeout
On Wed, Apr 17, 2019 at 11:18:32PM +0200, Wolfram Sang wrote:
>
> > > I have the following diff applied on top of patch 2. Works with and
> > > without a parent device. I am not super happy casting 'identity' but
> > > since its u8-type is exported to userspace, I think we can't avoid it.
> > > Guenter, is this cast safe? Here is the diff:
> > >
> > I would think it is safe, but question is if it is it needed - ie do you see
> > a warning if it isn't there ? Presumably yes; if so, let's just do it.
>
> Yes, the compiler rightfully complains otherwise.
>
> Do you prefer resending only patch 2 or the whole series?
>
Please resend the whole series; that simplifies tracking.

Thanks,
Guenter

\
 
 \ /
  Last update: 2019-04-18 00:01    [W:0.048 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site