lkml.org 
[lkml]   [2019]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH-tip 0/2] locking/rwsem: Rwsem rearchitecture part 2 follow-up patches
From
Date
On 04/16/2019 10:17 AM, Peter Zijlstra wrote:
> On Tue, Apr 16, 2019 at 09:18:50AM -0400, Waiman Long wrote:
>> On 04/16/2019 09:10 AM, Peter Zijlstra wrote:
>>> On Mon, Apr 15, 2019 at 04:58:27PM -0400, Waiman Long wrote:
>>>> This series contain 2 follow-up patches to alleviate the performance
>>>> regression found in the page_fault1 test of the will-it-scale benchmark.
>>>> This does not recover all the lost performance, but reclaim a sizeable
>>>> portion of it.
>>>>
>>>> The regression was found on an Intel system. I have run the test on
>>>> an AMD system. The regression wasn't seen there. There are only minor
>>>> variations in performance. Perhaps the page fault path is quite different
>>>> between Intel and AMD systems.
>>> Can you please just fold this back into the appropriate patches? Trying
>>> to review all the back and forth is painful.
>> I will send out an update part 2 patch with patch 1 of this series
>> merged into the writer spinning on reader patch. Patch 2 of this series
>> will be a standalone one.
> Hmm, in that case I can fold it back too. So hold off on sending it.
>
> I thought #2 was a fixup for an earlier patch as well.

#2 is a performance fix.

Cheers,
Longman


\
 
 \ /
  Last update: 2019-04-16 19:03    [W:0.081 / U:3.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site