[lkml]   [2019]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH wireless-drivers] rtlwifi: rtl8723ae: Fix missing break in switch statement

On 4/15/19 10:36 PM, Kalle Valo wrote:
> "Gustavo A. R. Silva" <> writes:
>> Add missing break statement in order to prevent the code from falling
>> through to case 0x1025, and erroneously setting rtlhal->oem_id to
>> RT_CID_819X_ACER when rtlefuse->eeprom_svid is equal to 0x10EC and
>> none of the cases in switch (rtlefuse->eeprom_smid) match.
>> This bug was found thanks to the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>> Fixes: 238ad2ddf34b ("rtlwifi: rtl8723ae: Clean up the hardware info routine")
>> Cc:
>> Signed-off-by: Gustavo A. R. Silva <>
> You have marked this for wireless-drivers but the commit is 2.5 years
> old, so I think wireless-drivers-next is more approriate.

Yeah. This can actually be applied to both of them. What I'd like is
to have this applied to stable, so I thought wireless-drivers was a
more straightforward way.

Anyway, I'll update the tag and respin.


 \ /
  Last update: 2019-04-16 17:09    [W:0.065 / U:2.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site