[lkml]   [2019]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCHv2 2/2] hmat: Register attributes for memory hot add
On Tue, Apr 16, 2019 at 04:55:21PM +0200, Brice Goglin wrote:
> Hello Keith
> Several issues:
> * We always get a memory_side_cache, even if nothing was found in ACPI.
> You should at least ignore the cache if size==0?
> * Your code seems to only work with a single level of cache, since
> there's a single cache_attrs entry in each target structure.
> * I was getting a section mismatch warning and a crash on PMEM node
> hotplug until I applied the patch below.
> WARNING: vmlinux.o(.text+0x47d3f7): Section mismatch in reference from the function hmat_callback() to the function .init.text:hmat_register_target()
> The function hmat_callback() references
> the function __init hmat_register_target().
> This is often because hmat_callback lacks a __init
> annotation or the annotation of hmat_register_target is wrong.
> Thanks
> Brice

Oh, thanks for the notice. I'll add multi-level and no-caches into my
test, as I had it fixed to one. Will need to respin this series.

 \ /
  Last update: 2019-04-16 17:00    [W:0.036 / U:5.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site