lkml.org 
[lkml]   [2019]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kernfs: fix barrier usage in __kernfs_new_node()
On Tue, Apr 16, 2019 at 02:17:11PM +0200, Andrea Parri wrote:
> smp_mb__before_atomic() can not be applied to atomic_set(). Remove the
> barrier and rely on RELEASE synchronization.
>
> Fixes: ba16b2846a8c6 ("kernfs: add an API to get kernfs node from inode number")
> Cc: stable@vger.kernel.org
> Signed-off-by: Andrea Parri <andrea.parri@amarulasolutions.com>
> ---
> fs/kernfs/dir.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/fs/kernfs/dir.c b/fs/kernfs/dir.c
> index b84d635567d38..1e7a74b8e0647 100644
> --- a/fs/kernfs/dir.c
> +++ b/fs/kernfs/dir.c
> @@ -650,11 +650,10 @@ static struct kernfs_node *__kernfs_new_node(struct kernfs_root *root,
> kn->id.generation = gen;
>
> /*
> - * set ino first. This barrier is paired with atomic_inc_not_zero in
> + * set ino first. This RELEASE is paired with atomic_inc_not_zero in
> * kernfs_find_and_get_node_by_ino
> */
> - smp_mb__before_atomic();
> - atomic_set(&kn->count, 1);
> + atomic_set_release(&kn->count, 1);

Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

--
tejun

\
 
 \ /
  Last update: 2019-04-16 16:48    [W:0.037 / U:5.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site