lkml.org 
[lkml]   [2019]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v2 1/3] security: Create "kernel hardening" config area
    On Tue, Apr 16, 2019 at 8:55 AM Alexander Popov <alex.popov@linux.com> wrote:
    >
    > On 16.04.2019 7:02, Kees Cook wrote:
    > > On Mon, Apr 15, 2019 at 11:44 AM Alexander Popov <alex.popov@linux.com> wrote:
    > >>
    > >> What do you think about some separator between memory initialization options and
    > >> CONFIG_CRYPTO?
    > >
    > > This was true before too
    >
    > Hm, yes, it's a generic behavior - there is no any separator at 'endmenu' and
    > config options stick together.
    >
    > I've created a patch to fix that. What do you think about it?
    > I can send it to LKML separately.
    >
    >
    > From 50bf59d30fafcdebb3393fb742e1bd51e7d2f2da Mon Sep 17 00:00:00 2001
    > From: Alexander Popov <alex.popov@linux.com>
    > Date: Tue, 16 Apr 2019 16:09:40 +0300
    > Subject: [PATCH 1/1] kconfig: Terminate menu blocks with a newline in the
    > generated config
    >
    > Currently menu blocks start with a pretty header but end with nothing in
    > the generated config. So next config options stick together with the
    > options from the menu block.
    >
    > Let's terminate menu blocks with a newline in the generated config.
    >
    > Signed-off-by: Alexander Popov <alex.popov@linux.com>
    > ---
    > scripts/kconfig/confdata.c | 2 ++
    > 1 file changed, 2 insertions(+)
    >
    > diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
    > index 08ba146..1459153 100644
    > --- a/scripts/kconfig/confdata.c
    > +++ b/scripts/kconfig/confdata.c
    > @@ -888,6 +888,8 @@ int conf_write(const char *name)
    > if (menu->next)
    > menu = menu->next;
    > else while ((menu = menu->parent)) {
    > + if (!menu->sym && menu_is_visible(menu))
    > + fprintf(out, "\n");
    > if (menu->next) {
    > menu = menu->next;
    > break;

    Seems fine to me. I defer to Masahiro, though. :)

    --
    Kees Cook

    \
     
     \ /
      Last update: 2019-04-16 15:58    [W:2.913 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site