lkml.org 
[lkml]   [2019]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: gasket: replace symbolic permissions with octal permissions
On Wed, Apr 10, 2019 at 03:58:48PM +0530, Himadri Pandya wrote:
> Resolve checkpatch warning for using symbolic permissions by replacing
> them with octal permissions.
>
> Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
> ---
> drivers/staging/gasket/gasket_sysfs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/gasket/gasket_sysfs.h b/drivers/staging/gasket/gasket_sysfs.h
> index 1d0eed66a7f4..28dc422d388c 100644
> --- a/drivers/staging/gasket/gasket_sysfs.h
> +++ b/drivers/staging/gasket/gasket_sysfs.h
> @@ -75,7 +75,7 @@ struct gasket_sysfs_attribute {
>
> #define GASKET_SYSFS_RO(_name, _show_function, _attr_type) \
> { \
> - .attr = __ATTR(_name, S_IRUGO, _show_function, NULL), \
> + .attr = __ATTR(_name, 0444, _show_function, NULL), \
> .data.attr_type = _attr_type \
> }

This has been rejected many times in the past as the real solution is to
use __ATTR_RO here.

thanks,

greg k-h

\
 
 \ /
  Last update: 2019-04-16 13:49    [W:0.060 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site