Messages in this thread | | | Date | Tue, 16 Apr 2019 12:31:54 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernels |
| |
On Tue, Apr 16, 2019 at 12:02:26PM +0200, Ingo Molnar wrote: > > * Borislav Petkov <bp@alien8.de> wrote: > > > I'll queue the below in the next days if there are no more complaints: > > Just a minor style nit, this was inherited from existing code: > > > + efi_config_table_64_t *tbl = (efi_config_table_64_t *) config_tables + i; > > + efi_config_table_32_t *tbl = (efi_config_table_32_t *) config_tables + i; > > You might want to update that to the canonical form of: > > > + efi_config_table_64_t *tbl = (efi_config_table_64_t *)config_tables + i; > > + efi_config_table_32_t *tbl = (efi_config_table_32_t *)config_tables + i; > > Looks good otherwise.
Fixed, thanks.
-- Regards/Gruss, Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
| |