lkml.org 
[lkml]   [2019]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernel
On Mon, Apr 15, 2019 at 11:00:25PM +0000, Junichi Nomura wrote:
> I thought we should hang here instead of return so that we
> don't run into efi_get_rsdp_addr() in case of kexec.

Hanging that early without debug output is not very friendly to
debuggers, methinks.

> > + ei = &boot_params->efi_info;
> > + sig = (char *)&ei->efi_loader_signature;
> > + if (strncmp(sig, EFI64_LOADER_SIGNATURE, 4)) {
> > + debug_putstr("Wrong kexec EFI loader signature.\n");
> > + return 0;
> > + }
>
> Same here.

Ditto.

You get the idea.

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

\
 
 \ /
  Last update: 2019-04-16 11:40    [W:0.067 / U:8.816 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site