lkml.org 
[lkml]   [2019]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fix warning and undefined behavior in mmc voltage handling
On Tue 2019-04-16 09:48:51, Ulf Hansson wrote:
> On Fri, 12 Apr 2019 at 11:34, Pavel Machek <pavel@ucw.cz> wrote:
> >
> > !voltage_ranges is tested for too late, allowing warning and undefined
> > behavior. Fix that.
> >
> > Signed-off-by: Pavel Machek <pavel@ucw.cz>
>
> Pavel, thanks for your patch.
>
> Would you mind re-posting to linux-mmc so I can get it into the
> patchtracker. Please also change the prefix of the header to "mmc:
> core:".

Done.

> > Plus I guess author should add parenthesis in the expression. a / b /
> > c is _not_ common idiom.

Can you do something about the a / b / c situation?

> > - num_ranges = num_ranges / sizeof(*voltage_ranges) / 2;
> > + num_ranges = num_ranges / sizeof(*voltage_ranges) / 2;

I guess it is:
num_ranges = (num_ranges / sizeof(*voltage_ranges)) / 2;

...but...

Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2019-04-16 10:01    [W:1.505 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site