Messages in this thread | | | Subject | Re: [PATCH] KVM: vmx: print more APICv fields in dump_vmcs | From | Krish Sadhukhan <> | Date | Tue, 16 Apr 2019 17:36:05 -0700 |
| |
On 04/15/2019 06:35 AM, Paolo Bonzini wrote: > The SVI, RVI, virtual-APIC page address and APIC-access page address fields > were left out of dump_vmcs. Add them. > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > --- > arch/x86/kvm/vmx/vmx.c | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c > index ab432a930ae8..f8054dc1de65 100644 > --- a/arch/x86/kvm/vmx/vmx.c > +++ b/arch/x86/kvm/vmx/vmx.c > @@ -5723,8 +5723,17 @@ static void dump_vmcs(void) > if (secondary_exec_control & SECONDARY_EXEC_TSC_SCALING) > pr_err("TSC Multiplier = 0x%016llx\n", > vmcs_read64(TSC_MULTIPLIER)); > - if (cpu_based_exec_ctrl & CPU_BASED_TPR_SHADOW) > - pr_err("TPR Threshold = 0x%02x\n", vmcs_read32(TPR_THRESHOLD)); > + if (cpu_based_exec_ctrl & CPU_BASED_TPR_SHADOW) { > + if (secondary_exec_control & SECONDARY_EXEC_VIRTUAL_INTR_DELIVERY) { > + u16 status = vmcs_read16(GUEST_INTR_STATUS); > + pr_err("SVI|RVI = %02x|%02x ", status >> 8, status & 0xff); > + } > + pr_err(KERN_CONT "TPR Threshold = 0x%02x\n", vmcs_read32(TPR_THRESHOLD)); > + if (secondary_exec_control & (SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES | > + SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE)) > + pr_err("APIC-access addr = 0x%016llx ", vmcs_read64(APIC_ACCESS_ADDR)); > + pr_err(KERN_CONT "virt-APIC addr=0x%016llx\n", vmcs_read64(VIRTUAL_APIC_PAGE_ADDR)); > + } > if (pin_based_exec_ctrl & PIN_BASED_POSTED_INTR) > pr_err("PostedIntrVec = 0x%02x\n", vmcs_read16(POSTED_INTR_NV)); > if ((secondary_exec_control & SECONDARY_EXEC_ENABLE_EPT))
Reviewed-by: Krish Sadhukhan <krish.sadhukhan@oracle.com>
| |