Messages in this thread |  | | Date | Tue, 16 Apr 2019 22:59:26 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH 2/2] x86/resctrl: Initialize new resource group with default MBA values |
| |
On Wed, Apr 17, 2019 at 04:51:18AM +0800, Xiaochen Shen wrote: > In this patch we initialize MBA resource and cache resources in separate > functions rdtgroup_init_cat() and rdtgroup_init_mba(). If > __init_one_rdt_domain() is only called by rdtgroup_init_cat(), how about > using function name "__init_one_rdt_domain_cat()"?
I guess but be conservative when adding too many words to a function's name - that might get heavy when reading the code later.
For example, there's an argument to not suffix it with "_cat": it is only called by rdtgroup_init_cat() - rdtgroup_init_mba() will not call it - so the path will remain unique anyway...
Anyway, something to think about - I personally don't have a strong preference here.
Thx.
-- Regards/Gruss, Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
|  |