Messages in this thread |  | | Date | Tue, 16 Apr 2019 21:01:48 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH v4 1/2] kernel/crash_core: separate the parsing routines to lib/parse_crashkernel.c |
| |
On Mon, Apr 08, 2019 at 01:58:34PM +0800, Pingfan Liu wrote: > Beside kernel, at early boot stage, the KASLR code also needs to parse the > crashkernel=x@y or crashkernel=ramsize-range:size[,...][@offset] option, > and avoid to put randomized kernel in the region. > > Extracting the parsing related routines to lib/parse_crashkernel.c, so it > will be handy included by other > files.
Use this commit message for your next submission:
crash: Carve out crashkernel= cmdline parsing
Make the "crashkernel=" parsing functionality available to the early KASLR code. Will be used by a later patch to parse crashkernel regions which KASLR should aviod.
> Signed-off-by: Pingfan Liu <kernelfans@gmail.com> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Ingo Molnar <mingo@redhat.com> > Cc: Borislav Petkov <bp@alien8.de> > Cc: "H. Peter Anvin" <hpa@zytor.com> > Cc: Baoquan He <bhe@redhat.com> > Cc: Will Deacon <will.deacon@arm.com> > Cc: Nicolas Pitre <nico@linaro.org> > Cc: Chao Fan <fanc.fnst@cn.fujitsu.com> > Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> > Cc: Vivek Goyal <vgoyal@redhat.com> > CC: Hari Bathini <hbathini@linux.vnet.ibm.com> > Cc: linux-kernel@vger.kernel.org > --- > kernel/crash_core.c | 273 --------------------------------------------- > lib/Makefile | 2 + > lib/parse_crashkernel.c | 289 ++++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 291 insertions(+), 273 deletions(-)
And this is not how you carve out code.
First, you do a patch which does only code move. Nothing more.
In a follow on patch, you make the changes to the moved code so that it is immediately visible what you're changing.
-- Regards/Gruss, Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
|  |