[lkml]   [2019]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v4 1/9] clkdev: Hold clocks_mutex while iterating clocks list
On Fri, Apr 12, 2019 at 11:31:42AM -0700, Stephen Boyd wrote:
> We recently introduced a change to support devm clk lookups. That change
> introduced a code-path that used clk_find() without holding the
> 'clocks_mutex'. Unfortunately, clk_find() iterates over the 'clocks'
> list and so we need to prevent the list from being modified at the same
> time. Do this by holding the mutex and checking to make sure it's held
> while iterating the list.
> Note, we don't really care if the lookup is freed after we find it with
> clk_find() because we're just doing a pointer comparison, but if we did
> care we would need to keep holding the mutex while we dereference the
> clk_lookup pointer.
> Fixes: 3eee6c7d119c ("clkdev: add managed clkdev lookup registration")
> Cc: Miquel Raynal <>
> Cc: Jerome Brunet <>
> Cc: Russell King <>
> Cc: Michael Turquette <>
> Cc: Jeffrey Hugo <>
> Cc: Chen-Yu Tsai <>
> Cc: Matti Vaittinen <>
> Signed-off-by: Stephen Boyd <>
Acked-By: Matti Vaittinen <>

 \ /
  Last update: 2019-04-15 07:23    [W:0.107 / U:5.808 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site