lkml.org 
[lkml]   [2019]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [alsa-devel] [PATCH] soundwire: cdns: Fix compilation error on arm64
From
Date

>> diff --git a/drivers/soundwire/cadence_master.c b/drivers/soundwire/cadence_master.c
>> index cb6a331f4..0b5bcc209 100644
>> --- a/drivers/soundwire/cadence_master.c
>> +++ b/drivers/soundwire/cadence_master.c
>> @@ -9,6 +9,7 @@
>> #include <linux/delay.h>
>> #include <linux/device.h>
>> #include <linux/interrupt.h>
>> +#include <linux/io.h>
>
> Why not add asm/io.h which is the header that actually defines
> readl/writel?

The vast majority of kernel code uses linux/io.h.
We use linux/io.h for SOF as well.

>
>> #include <linux/module.h>
>> #include <linux/mod_devicetable.h>
>> #include <linux/soundwire/sdw_registers.h>
>> --
>> 2.15.0
>

\
 
 \ /
  Last update: 2019-04-15 14:41    [W:0.042 / U:4.836 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site