lkml.org 
[lkml]   [2019]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: misuse of fget_raw() in perf_event_get()
On Sat, Apr 13, 2019 at 10:02:42PM +0100, Al Viro wrote:
> What's the point of using fget_raw(), if you do
> _not_ accept O_PATH descriptors? That should be fget()...

I think you're talking about commit e03e7ee34fdd ("perf/bpf: Convert perf_event_array to use struct file")
I don't really remember why we went with this instead of fget().
There was a bunch of back and forth back then with Peter.
Now it looks like that it can be fget just fine.
I think cgroup_get_from_fd() should do the same too?

\
 
 \ /
  Last update: 2019-04-15 06:42    [W:0.021 / U:27.768 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site