lkml.org 
[lkml]   [2019]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] printk: tie printk_once / printk_deferred_once into .data.once for reset
On Mon 2019-04-15 11:32:16, Sergey Senozhatsky wrote:
> On (04/12/19 22:11), Paul Gortmaker wrote:
> > In commit b1fca27d384e ("kernel debug: support resetting WARN*_ONCE")
> > we got the opportunity to reset state on the one shot messages,
> > without having to reboot.
>
> Didn't know that.
>
> > However printk_once (printk_deferred_once) live in a different file
> > and didn't get the same kind of update/conversion, so they remain
> > unconditionally one shot, until the system is rebooted.
> >
> > For example, we currently have:
> >
> > sched/rt.c: printk_deferred_once("sched: RT throttling activated\n");
> >
> > ..which could reasonably be tripped as someone is testing and tuning
> > a new system/workload and their task placements. For consistency, and
> > to avoid reboots in the same vein as the original commit, we make these
> > two instances of _once the same as the WARN*_ONCE instances are.
>
> Looks OK to me.
>
> Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

The patch has been commited into printk.git, branch for-5.2.

Best Regards,
Petr

\
 
 \ /
  Last update: 2019-04-15 14:35    [W:0.028 / U:1.956 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site