lkml.org 
[lkml]   [2019]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH V5 1/7] jump_label: Add for_each_label_entry helper
From
Date
On 4/15/19 12:51 PM, Peter Zijlstra wrote:
>> +#define for_each_label_entry(key, entry, stop) \
>> + for (; (entry < stop) && (jump_entry_key(entry) == key); entry++)
>> +
> I don't really like this naming; most (all?) for_each_*() loops start
> iteration and have the iteration variable as first argument.
>
> This should maybe be called:
>
> for_each_jump_entry_by_key_cont(entry, stop, key)
>
> and I realize that is a horrible name too.

Borislav did not like this helper too, so I am convinced: we do not need it. I
will remove it in the next version.

-- Daniel

\
 
 \ /
  Last update: 2019-04-15 13:31    [W:0.030 / U:11.004 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site