lkml.org 
[lkml]   [2019]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] smp: Do not warn if smp_call_function_single() is doing a self call.
Date
> From: Peter Zijlstra <peterz@infradead.org>
> Sent: Monday, April 15, 2019 5:21 AM
> To: Dexuan Cui <decui@microsoft.com>
>
> On Fri, Apr 12, 2019 at 11:53:57PM +0000, Dexuan Cui wrote:
> > If smp_call_function_single() is calling the function for itself, it's safe
> > to run with irqs_disabled() == true.
> >
> > I hit the warning because I'm in the below path in the .suspend callback of
> > a "syscore_ops" to support hibernation for a VM running on Hyper-V:
> >
> > hv_synic_cleanup() ->
> > clockevents_unbind_device() ->
> > clockevents_unbind() ->
> > smp_call_function_single().
> >
> > When the .suspend callback runs, only CPU0 is online and irqs_disabled() is
> > true.
>
> Pray tell, how well do you think mutex_lock() works with interrupts
> disabled?

Good point. I realized generally speaking this patch makes no sense, so let me
try the solution proposed by Vitaly, i.e. fix clockevents_unbind() instead.

Thanks,
-- Dexuan

\
 
 \ /
  Last update: 2019-04-16 01:41    [W:0.055 / U:0.656 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site