| Subject | Re: [PATCH 02/12] drm/tegra: rgb: add missing of_node_put after of_device_is_available | From | Markus Elfring <> | Date | Sun, 14 Apr 2019 17:01:23 +0200 |
| |
> @@ -221,8 +221,10 @@ int tegra_dc_rgb_probe(struct tegra_dc * > int err; > > np = of_get_child_by_name(dc->dev->of_node, "rgb"); > - if (!np || !of_device_is_available(np)) > + if (!np || !of_device_is_available(np)) { > + of_node_put(np); > return -ENODEV; > + } > > rgb = devm_kzalloc(dc->dev, sizeof(*rgb), GFP_KERNEL); > if (!rgb)
How do you think about to move this function call to an additional jump target for the desired exception handling?
Regards, Markus
|