[lkml]   [2019]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[tip:x86/urgent] x86/resctrl: Do not repeat rdtgroup mode initialization
Commit-ID:  40fba00ffa431c8597ca785ea1cfa4d9f6503390
Author: Xiaochen Shen <>
AuthorDate: Wed, 10 Apr 2019 03:53:49 +0800
Committer: Borislav Petkov <>
CommitDate: Sun, 14 Apr 2019 18:23:13 +0200

x86/resctrl: Do not repeat rdtgroup mode initialization

When cache allocation is supported and the user creates a new resctrl
resource group, the allocations of the new resource group are
initialized to all regions that it can possibly use. At this time these
regions are all that are shareable by other resource groups as well as
regions that are not currently used. The new resource group's mode is
also initialized to reflect this initialization and set to "shareable".

The new resource group's mode is currently repeatedly initialized within
the loop that configures the hardware with the resource group's default

Move the initialization of the resource group's mode outside the
hardware configuration loop. The resource group's mode is now
initialized only once as the final step to reflect that its configured
allocations are "shareable".

Fixes: 95f0b77efa57 ("x86/intel_rdt: Initialize new resource group with sane defaults")
Signed-off-by: Xiaochen Shen <>
Signed-off-by: Borislav Petkov <>
Reviewed-by: Fenghua Yu <>
Acked-by: Reinette Chatre <>
Cc: "H. Peter Anvin" <>
Cc: Ingo Molnar <>
Cc: Thomas Gleixner <>
Cc: Tony Luck <>
Cc: x86-ml <>
arch/x86/kernel/cpu/resctrl/rdtgroup.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
index 54b9eef3eea9..85212a32b54d 100644
--- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c
+++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
@@ -2610,9 +2610,10 @@ static int rdtgroup_init_alloc(struct rdtgroup *rdtgrp)
rdt_last_cmd_puts("Failed to initialize allocations\n");
return ret;
- rdtgrp->mode = RDT_MODE_SHAREABLE;

+ rdtgrp->mode = RDT_MODE_SHAREABLE;
return 0;

 \ /
  Last update: 2019-04-14 18:42    [W:0.057 / U:0.924 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site