lkml.org 
[lkml]   [2019]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [11/12] ARM: OMAP2+: add missing of_node_put after of_device_is_available
From
Date
> @@ -250,8 +250,10 @@ static int __init omapdss_init_of(void)
> if (!node)
> return 0;
>
> - if (!of_device_is_available(node))
> + if (!of_device_is_available(node)) {
> + of_node_put(node);
> return 0;
> + }
>
> pdev = of_find_device_by_node(node);

Is there a need to put the node also in subsequent if branches
for complete exception handling in this function implementation?

Regards,
Markus

\
 
 \ /
  Last update: 2019-04-14 18:38    [W:1.438 / U:9.708 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site