lkml.org 
[lkml]   [2019]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 net-next 18/24] net: dsa: sja1105: Add support for traffic through standalone ports
> > > > > +             return dsa_8021q_xmit(skb, netdev, ETH_P_EDSA,
> > > > > + ((pcp << VLAN_PRIO_SHIFT) | tx_vid));
> > > >
> > > > Please don't reuse ETH_P_EDSA. Define an ETH_P_SJA1105.
> > > >
>
> I'm receiving contradictory advice on this. Why should I define a new
> ethertype, and if I do, what scope should the definition have (local
> to the driver and the tagger, local to DSA, UAPI)?

ETH_P_EDSA has a well defined meaning. It is a true global EtherType,
and means a Marvell EtherType DSA header follows.

You are polluting this meaning of ETH_P_EDSA. Would you put ETH_P_IP
or ETH_P_8021AD here?

Andrew

\
 
 \ /
  Last update: 2019-04-14 18:19    [W:0.073 / U:13.948 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site