[lkml]   [2019]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH] ARM: STi: at least warn if of_iomap fails
The call to of_iomap() is unchecked but scu_enable(), which the returned
address is passed on to, assumes a valid mapping. If the mapping is
invalid this could probably lead to undefined system state so at least
a warning should be issued.

Signed-off-by: Nicholas Mc Guire <>
Fixes: commit 65ebcc115889 ("ARM: sti: Add STiH415 SOC support")
Problem was found by an experimental coccinelle script

Patch was compile tested with: multi_v7_defconfig (implies

Patch is against 4.18-rc3 (localversion-next is next-20180712)

arch/arm/mach-sti/platsmp.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-sti/platsmp.c b/arch/arm/mach-sti/platsmp.c
index 231f19e..89ae76f 100644
--- a/arch/arm/mach-sti/platsmp.c
+++ b/arch/arm/mach-sti/platsmp.c
@@ -109,6 +109,7 @@ static void __init sti_smp_prepare_cpus(unsigned int max_cpus)

if (np) {
scu_base = of_iomap(np, 0);
+ WARN_ON(!scu_base);
 \ /
  Last update: 2019-04-13 09:22    [W:0.119 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site