Messages in this thread | | | From | Andrey Smirnov <> | Date | Sat, 13 Apr 2019 18:05:04 -0700 | Subject | Re: [PATCH 5/6] iio: imx7d_adc: Use imx7d_adc_resume() in imx7d_adc_probe() |
| |
On Sun, Apr 7, 2019 at 4:15 AM Jonathan Cameron <jic23@kernel.org> wrote: > > On Wed, 3 Apr 2019 00:03:24 -0700 > Andrey Smirnov <andrew.smirnov@gmail.com> wrote: > > > Initialization sequence performed in imx7d_adc_resume() is exactley > > the same as what's being done in imx7d_adc_probe(). Make use of the > > former in the latter to avoid code duplication. > > > > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> > > Cc: Jonathan Cameron <jic23@kernel.org> > > Cc: Hartmut Knaack <knaack.h@gmx.de> > > Cc: Lars-Peter Clausen <lars@metafoo.de> > > Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net> > > Cc: Chris Healy <cphealy@gmail.com> > > Cc: linux-iio@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > I'm not to going to apply this now, due to the ordering issue with the earlier > and later patches. However, it is fine in of itself. > > I do wonder if we want to rename resume to something else to reflect > it's new usage? imx7d_adc_enable perhaps? > Similar question for suspend in the next patch.
Sure, will rename in v2.
Thanks, Andrey Smirnov
| |