Messages in this thread | | | Subject | Re: [PATCH 1/2] driver core: printk to pr_* | From | Joe Perches <> | Date | Sat, 13 Apr 2019 09:57:27 -0700 |
| |
On Fri, 2019-04-12 at 16:47 +0100, Willy Wolff wrote: > Signed-off-by: Willy Wolff <willy.mh.wolff.ml@gmail.com>
Most people seem to prefer some type of commit message before your sign-off.
And trivia:
> diff --git a/drivers/base/dd.c b/drivers/base/dd.c [] > @@ -602,8 +601,8 @@ static int really_probe_debug(struct device *dev, struct device_driver *drv) > ret = really_probe(dev, drv); > rettime = ktime_get(); > delta = ktime_sub(rettime, calltime); > - printk(KERN_DEBUG "probe of %s returned %d after %lld usecs\n", > - dev_name(dev), ret, (s64) ktime_to_us(delta)); > + pr_debug("probe of %s returned %d after %lld usecs\n", > + dev_name(dev), ret, (s64) ktime_to_us(delta));
While I think this particular change is fine, and you may already know this, but converting a printk(KERN_DEBUG ...) to pr_debug(...) changes object code and output.
The first is always emitted, the second is not emitted unless DEBUG is defined or CONFIG_DYNAMIC_DEBUG is enabled.
Your commit message should show this understanding.
| |