Messages in this thread | | | Subject | Re: [PATCH][V2] brcmfmac: fix leak of mypkt on error return path | From | Kalle Valo <> | Date | Sat, 13 Apr 2019 11:08:03 +0000 (UTC) |
| |
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com> > > Currently if the call to brcmf_sdiod_set_backplane_window fails then > error return path leaks mypkt. Fix this by returning by a new > error path labelled 'out' that calls brcmu_pkt_buf_free_skb to free > mypkt. Also remove redundant check on err before calling > brcmf_sdiod_skbuff_write. > > Addresses-Coverity: ("Resource Leak") > Fixes: a7c3aa1509e2 ("brcmfmac: Remove brcmf_sdiod_addrprep()") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Patch applied to wireless-drivers-next.git, thanks.
a927e8d8ab57 brcmfmac: fix leak of mypkt on error return path
-- https://patchwork.kernel.org/patch/10891135/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
| |