Messages in this thread | | | Subject | Re: [PATCH][V3] scsi: cxgbi: remove redundant __kfree_skb call on skb and free cst->atid | From | "Martin K. Petersen" <> | Date | Fri, 12 Apr 2019 20:06:01 -0400 |
| |
Colin,
> The error return path via label rel_resource checks for a non-null skb > before free'ing it. However, skb is always null at this exit path, so > the null check and the free are redundant and can be removed. > Removing this allows the original goto's to rel_resource to be cleaned > up; the first can be replaced by a return of -EINVAL, the second can > be replaced by a more appropriate -ENOMEM return and fix a memory leak > by freeing csk->atid.
Applied to 5.2/scsi-queue, thanks!
-- Martin K. Petersen Oracle Linux Engineering
| |