lkml.org 
[lkml]   [2019]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 1/4] x86: kdump: move reserve_crashkernel_low() into kexec_core.c

* Chen Zhou <chenzhou10@huawei.com> wrote:

> Hi Ingo,
>
> On 2019/4/10 15:09, Ingo Molnar wrote:
> >
> > * Chen Zhou <chenzhou10@huawei.com> wrote:
> >
> >> In preparation for supporting more than one crash kernel regions
> >> in arm64 as x86_64 does, move reserve_crashkernel_low() into
> >> kexec/kexec_core.c.
> >>
> >> Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
> >> ---
> >> arch/x86/include/asm/kexec.h | 3 ++
> >> arch/x86/kernel/setup.c | 66 +++++---------------------------------------
> >> include/linux/kexec.h | 1 +
> >> kernel/kexec_core.c | 53 +++++++++++++++++++++++++++++++++++
> >> 4 files changed, 64 insertions(+), 59 deletions(-)
> >
> > No objections for this to be merged via the ARM tree, as long as x86
> > functionality is kept intact.
>
> This patch has no affect on x86.

In *principle*.

In practice the series does change x86 code:

> >> arch/x86/kernel/setup.c | 66 +++++---------------------------------------
> >> include/linux/kexec.h | 1 +
> >> kernel/kexec_core.c | 53 +++++++++++++++++++++++++++++++++++

which is, *hopefully*, an identity transformation. :-)

I.e. Ack, but only if it doesn't break anything. :-)

Thanks,

Ingo

\
 
 \ /
  Last update: 2019-04-12 09:01    [W:0.058 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site