lkml.org 
[lkml]   [2019]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v5 2/4] coresight: replicator: Add new device id for static replicator
From
Date
On 04/12/2019 11:27 AM, Leo Yan wrote:
> This patch adds a device id for the new static replicator compatible
> string; it changes the driver name from "coresight-replicator" to
> "coresight-static-replicator" as well.
>
> This patch also gives warning when use the replicator obsolete DT
> binding.
>
> Signed-off-by: Leo Yan <leo.yan@linaro.org>
> ---
> drivers/hwtracing/coresight/coresight-replicator.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c
> index 4e0da85efd2d..8c9ce74498e1 100644
> --- a/drivers/hwtracing/coresight/coresight-replicator.c
> +++ b/drivers/hwtracing/coresight/coresight-replicator.c
> @@ -189,6 +189,9 @@ static int replicator_probe(struct device *dev, struct resource *res)
> dev->platform_data = pdata;
> }
>
> + if (of_device_is_compatible(np, "arm,coresight-replicator"))
> + pr_warn_once("Uses OBSOLETE CoreSight replicator binding\n");
> +
> drvdata = devm_kzalloc(dev, sizeof(*drvdata), GFP_KERNEL);
> if (!drvdata)
> return -ENOMEM;
> @@ -285,13 +288,14 @@ static const struct dev_pm_ops replicator_dev_pm_ops = {
>
> static const struct of_device_id static_replicator_match[] = {
> {.compatible = "arm,coresight-replicator"},
> + {.compatible = "arm,coresight-static-replicator"},
> {}
> };
>
> static struct platform_driver static_replicator_driver = {
> .probe = static_replicator_probe,
> .driver = {
> - .name = "coresight-replicator",
> + .name = "coresight-static-replicator",
> .of_match_table = static_replicator_match,
> .pm = &replicator_dev_pm_ops,
> .suppress_bind_attrs = true,
>

Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>

\
 
 \ /
  Last update: 2019-04-12 12:39    [W:0.079 / U:0.832 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site