lkml.org 
[lkml]   [2019]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/5] lib/test_bitmap: add testcases for bitmap_parselist
On Thu, Apr 11, 2019 at 11:39:46AM -0700, Guenter Roeck wrote:
> On Fri, Apr 05, 2019 at 08:32:10PM +0300, Yury Norov wrote:
> > Add tests for non-number character, empty regions, integer overflow.

> > {0, "1-31:4/4", &exp[9 * step], 32, 0},
> > {0, "0-31:1/4,32-63:2/4", &exp[10 * step], 64, 0},
> > {0, "0-31:3/4,32-63:4/4", &exp[11 * step], 64, 0},
> > + {0, " ,, 0-31:3/4 ,, 32-63:4/4 ,, ", &exp[11 * step], 64, 0},
> >
> > {0, "0-31:1/4,32-63:2/4,64-95:3/4,96-127:4/4", exp2, 128, 0},
> >
> > {0, "0-2047:128/256", NULL, 2048, PARSE_TIME},
> >
> > + {0, "", &exp[12], 8, 0},
> > + {0, "\n", &exp[12], 8, 0},
> > + {0, ",, ,, , , ,", &exp[12], 8, 0},
> > + {0, " , ,, , , ", &exp[12], 8, 0},
> > + {0, " , ,, , , \n", &exp[12], 8, 0},
> > +
>
> This results in error messages such as
>
> test_bitmap: parselist: 17: input is ,, ,, , , ,, result is 0x0, expected 0x11111111
> test_bitmap: parselist: 18: input is , ,, , , , result is 0x0, expected 0x11111111
>
> on 32-bit systems. The above should be "&exp[12 * step]".

Nice catch!

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2019-04-12 10:41    [W:0.048 / U:29.056 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site