Messages in this thread | | | Date | Thu, 11 Apr 2019 12:36:14 -0700 | From | Nathan Chancellor <> | Subject | Re: [PATCH] clocksource/drivers/timer-ti-dm: Remove omap_dm_timer_set_load_start |
| |
On Thu, Apr 11, 2019 at 09:20:56PM +0200, Daniel Lezcano wrote: > On 10/04/2019 22:07, Tony Lindgren wrote: > > Hi, > > > > * Daniel Lezcano <daniel.lezcano@linaro.org> [190410 17:02]: > >> can you ask for an acked-by before pulling a patch in your tree? > > > > I certainly do ask and wait for acks where possible :) > > Ok, I may have missed them. > > > Note that I have not applied this patch. I just added > > Keerthy to Cc on this thread so maybe you misread the > > message earlier. My comment "seems like no other > > takers" was for Ladislav regarding somebody picking up > > his earlier work, not for picking up this patch :) > > Actually I was referring to the commit 592ea6bd1fad. Anyway as stated > above I could have miss your call. > > > In any case, I've been waiting for you guys to pick up > > the patch, here's my ack if you're waiting for it: > > > > Acked-by: Tony Lindgren <tony@atomide.com> > > The patch does not apply. Is it aligned with tip/timers/core ? >
The commit this fixes is in timers/urgent and it doesn't look like that has been backmerged into timers/core.
Nathan
> >> On 04/04/2019 16:17, Tony Lindgren wrote: > >>> * Ladislav Michl <ladis@linux-mips.org> [190327 08:12]: > >>>> Hello Nathan, > >>>> > >>>> On Tue, Mar 26, 2019 at 10:01:27PM -0700, Nathan Chancellor wrote: > >>>>> Commit 008258d995a6 ("clocksource/drivers/timer-ti-dm: Make > >>>>> omap_dm_timer_set_load_start() static") made omap_dm_time_set_load_start > >>>>> static because its prototype was not defined in a header. Unfortunately, > >>>>> this causes a build warning on multi_v7_defconfig because this function > >>>>> is not used anywhere in this translation unit: > >>>>> > >>>>> drivers/clocksource/timer-ti-dm.c:589:12: error: unused function > >>>>> 'omap_dm_timer_set_load_start' [-Werror,-Wunused-function] > >>>>> > >>>>> In fact, omap_dm_timer_set_load_start hasn't been used anywhere since > >>>>> commit f190be7f39a5 ("staging: tidspbridge: remove driver") and the > >>>>> prototype was removed in commit 592ea6bd1fad ("clocksource: timer-ti-dm: > >>>>> Make unexported functions static"), which is probably where this should > >>>>> have happened. > >>>> > >>>> Alternatively you might want to look at "clocksource: timer-ti-dm: Add event > >>>> capture": https://patchwork.kernel.org/patch/10237217/ (it makes use of > >>>> function being removed here). It is a part of an attempt to add event capture > >>>> for OMAP. Of course I would like this functionality to be implemented, but > >>>> as I do not have a time to continue, I cannot really object removing this > >>>> function. > >>>> > >>>> Just in case you'd be interested in finishing this task ;-) > >>> > >>> Well seems like no other takers :) We can always find the missing > >>> function in git history when needed, so I suggest we apply this. > >>> > >>> Adding Keerthy to Cc as he just posted a similar patch. > >>> > >>> Regards, > >>> > >>> Tony > >>> > >> > >> > >> -- > >> <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs > >> > >> Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | > >> <http://twitter.com/#!/linaroorg> Twitter | > >> <http://www.linaro.org/linaro-blog/> Blog > >> > > > -- > <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs > > Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | > <http://twitter.com/#!/linaroorg> Twitter | > <http://www.linaro.org/linaro-blog/> Blog >
| |