lkml.org 
[lkml]   [2019]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH net-next 12/12] net: hns3: code optimization for command queue' spin lock
    Date
    From: Peng Li <lipeng321@huawei.com>

    This patch removes some redundant BH disable when initialization
    and uninitialization command queue.

    Signed-off-by: Peng Li <lipeng321@huawei.com>
    Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
    ---
    drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c | 4 ++--
    drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_cmd.c | 4 ++--
    2 files changed, 4 insertions(+), 4 deletions(-)

    diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c
    index cf7ff4a..fbd904e 100644
    --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c
    +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c
    @@ -355,7 +355,7 @@ int hclge_cmd_init(struct hclge_dev *hdev)
    int ret;

    spin_lock_bh(&hdev->hw.cmq.csq.lock);
    - spin_lock_bh(&hdev->hw.cmq.crq.lock);
    + spin_lock(&hdev->hw.cmq.crq.lock);

    hdev->hw.cmq.csq.next_to_clean = 0;
    hdev->hw.cmq.csq.next_to_use = 0;
    @@ -364,7 +364,7 @@ int hclge_cmd_init(struct hclge_dev *hdev)

    hclge_cmd_init_regs(&hdev->hw);

    - spin_unlock_bh(&hdev->hw.cmq.crq.lock);
    + spin_unlock(&hdev->hw.cmq.crq.lock);
    spin_unlock_bh(&hdev->hw.cmq.csq.lock);

    clear_bit(HCLGE_STATE_CMD_DISABLE, &hdev->state);
    diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_cmd.c b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_cmd.c
    index 054556e..1b428d4 100644
    --- a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_cmd.c
    +++ b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_cmd.c
    @@ -334,7 +334,7 @@ int hclgevf_cmd_init(struct hclgevf_dev *hdev)
    int ret;

    spin_lock_bh(&hdev->hw.cmq.csq.lock);
    - spin_lock_bh(&hdev->hw.cmq.crq.lock);
    + spin_lock(&hdev->hw.cmq.crq.lock);

    /* initialize the pointers of async rx queue of mailbox */
    hdev->arq.hdev = hdev;
    @@ -348,7 +348,7 @@ int hclgevf_cmd_init(struct hclgevf_dev *hdev)

    hclgevf_cmd_init_regs(&hdev->hw);

    - spin_unlock_bh(&hdev->hw.cmq.crq.lock);
    + spin_unlock(&hdev->hw.cmq.crq.lock);
    spin_unlock_bh(&hdev->hw.cmq.csq.lock);

    clear_bit(HCLGEVF_STATE_CMD_DISABLE, &hdev->state);
    --
    2.7.4
    \
     
     \ /
      Last update: 2019-04-11 14:27    [W:4.967 / U:0.808 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site