Messages in this thread Patch in this message | | | Date | Thu, 11 Apr 2019 20:01:12 -0700 | From | Josh Triplett <> | Subject | Re: [PATCH v4 1/5] init: Introduce DEBUG_MISC option |
| |
On Fri, Apr 12, 2019 at 01:43:51AM +0000, Sinan Kaya wrote: > Introduce DEBUG_MISC ("Miscellaneous debug code that should be under a more > specific debug option but isn't"), make it depend on DEBUG_KERNEL and be > "default DEBUG_KERNEL" but allow itself to be turned off, and then > mechanically change the small handful of "#ifdef CONFIG_DEBUG_KERNEL" to > "#ifdef CONFIG_DEBUG_MISC". > > Signed-off-by: Sinan Kaya <okaya@kernel.org>
Minor typo below; with that: Reviewed-by: Josh Triplett <josh@joshtriplett.org>
And thank you!
> --- > lib/Kconfig.debug | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > index 0d9e81779e37..2f80ebaa6d9a 100644 > --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > @@ -438,6 +438,15 @@ config DEBUG_KERNEL > Say Y here if you are developing drivers or trying to debug and > identify kernel problems. > > +config DEBUG_MISC > + bool "Miscellaneous debug code" > + default DEBUG_KERNEL > + depends on DEBUG_KERNEL > + help > + Say Y here if you need to enable Miscellaneous debug code that should
Nit: s/Miscellaneous/miscellaneous/
> + be under a more specific debug option but isn't. > + > + > menu "Memory Debugging" > > source "mm/Kconfig.debug" > -- > 2.21.0 >
| |