lkml.org 
[lkml]   [2019]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 04/22] watchdog: ts72xx_wdt: Use 'dev' instead of dereferencing it repeatedly
    Date
    Introduce local variable 'struct device *dev' and use it instead of
    dereferencing it repeatedly.

    The conversion was done automatically with coccinelle using the
    following semantic patches. The semantic patches and the scripts
    used to generate this commit log are available at
    https://github.com/groeck/coccinelle-patches

    Signed-off-by: Guenter Roeck <linux@roeck-us.net>
    ---
    drivers/watchdog/ts72xx_wdt.c | 11 ++++++-----
    1 file changed, 6 insertions(+), 5 deletions(-)

    diff --git a/drivers/watchdog/ts72xx_wdt.c b/drivers/watchdog/ts72xx_wdt.c
    index 3aa11c84dea9..bf918f5fa131 100644
    --- a/drivers/watchdog/ts72xx_wdt.c
    +++ b/drivers/watchdog/ts72xx_wdt.c
    @@ -122,11 +122,12 @@ static const struct watchdog_ops ts72xx_wdt_ops = {

    static int ts72xx_wdt_probe(struct platform_device *pdev)
    {
    + struct device *dev = &pdev->dev;
    struct ts72xx_wdt_priv *priv;
    struct watchdog_device *wdd;
    int ret;

    - priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
    + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
    if (!priv)
    return -ENOMEM;

    @@ -143,20 +144,20 @@ static int ts72xx_wdt_probe(struct platform_device *pdev)
    wdd->ops = &ts72xx_wdt_ops;
    wdd->min_timeout = 1;
    wdd->max_hw_heartbeat_ms = 8000;
    - wdd->parent = &pdev->dev;
    + wdd->parent = dev;

    watchdog_set_nowayout(wdd, nowayout);

    wdd->timeout = TS72XX_WDT_DEFAULT_TIMEOUT;
    - watchdog_init_timeout(wdd, timeout, &pdev->dev);
    + watchdog_init_timeout(wdd, timeout, dev);

    watchdog_set_drvdata(wdd, priv);

    - ret = devm_watchdog_register_device(&pdev->dev, wdd);
    + ret = devm_watchdog_register_device(dev, wdd);
    if (ret)
    return ret;

    - dev_info(&pdev->dev, "TS-72xx Watchdog driver\n");
    + dev_info(dev, "TS-72xx Watchdog driver\n");

    return 0;
    }
    --
    2.7.4
    \
     
     \ /
      Last update: 2019-04-10 18:29    [W:2.687 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site