Messages in this thread | | | Subject | Re: [PATCH 23/23] watchdog: tangox_wdt: Convert to use device managed functions and other improvements | From | Marc Gonzalez <> | Date | Wed, 10 Apr 2019 15:04:56 +0200 |
| |
On 09/04/2019 19:24, Guenter Roeck wrote:
> Use device managed functions to simplify error handling, reduce > source code size, improve readability, and reduce the likelyhood of bugs. > Other improvements as listed below. > > The conversion was done automatically with coccinelle using the > following semantic patches. The semantic patches and the scripts > used to generate this commit log are available at > https://github.com/groeck/coccinelle-patches > > - Drop assignments to otherwise unused variables > - Drop unnecessary braces around conditional return statements > - Drop empty remove function > - Use devm_add_action_or_reset() for calls to clk_disable_unprepare > - Replace stop on remove with call to watchdog_stop_on_unregister() > - Use devm_watchdog_register_driver() to register watchdog device
No devm_clk_prepare() in mainline? :-(
https://lore.kernel.org/patchwork/patch/755487/
Regards.
| |