Messages in this thread | | | Date | Wed, 10 Apr 2019 14:28:14 +0200 | From | Oscar Salvador <> | Subject | Re: [PATCH] mm/memory_hotplug: Drop memory device reference after find_memory_block() |
| |
On Wed, Apr 10, 2019 at 12:14:55PM +0200, David Hildenbrand wrote: > While current node handling is probably terribly broken for memory block > devices that span several nodes (only possible when added during boot, > and something like that should be blocked completely), properly put the > device reference we obtained via find_memory_block() to get the nid.
We even have nodes sharing sections, so tricky to "fix". But I agree that the way memblocks are being handled now sucks big time.
> > Fixes: d0dc12e86b31 ("mm/memory_hotplug: optimize memory hotplug") > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Oscar Salvador <osalvador@suse.de> > Cc: Michal Hocko <mhocko@suse.com> > Cc: David Hildenbrand <david@redhat.com> > Cc: Pavel Tatashin <pasha.tatashin@soleen.com> > Cc: Wei Yang <richard.weiyang@gmail.com> > Cc: Qian Cai <cai@lca.pw> > Cc: Arun KS <arunks@codeaurora.org> > Cc: Mathieu Malaterre <malat@debian.org> > Signed-off-by: David Hildenbrand <david@redhat.com>
Well spotted David ;-)
Reviewed-by: Oscar Salvador <osalvador@suse.de>
-- Oscar Salvador SUSE L3
| |