Messages in this thread | | | Date | Wed, 10 Apr 2019 12:10:32 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 2/3] ASoC: add hikey960-i2s DT bindings |
| |
On Thu, Feb 28, 2019 at 09:57:41PM +0800, Pengcheng Li wrote:
> +Required properties: > + > +- compatible: should be one of the following: > + - "hisilicon,hi3660-i2s-1.0" > +- reg: physical base address of the i2s controller unit and length of > + memory mapped region.
This binding is inaccurate for the code as it requires two memory regions, one for the IP and one for the system controller. However as I said in the review of the driver you should probably be using the standard syscon binding for the system controller. [unhandled content-type:application/pgp-signature] | |