lkml.org 
[lkml]   [2019]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 1/5] soundwire: intel: fix inversion in devm_kcalloc parameters
    Date
    the number of elements and size are inverted, fix.

    This probably only worked because the number of properties is
    hard-coded to 1.

    Fixes: 71bb8a1b059e ('soundwire: intel: Add Intel Master driver')
    Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
    ---
    drivers/soundwire/intel.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c
    index fd8d034cfec1..8669b314c476 100644
    --- a/drivers/soundwire/intel.c
    +++ b/drivers/soundwire/intel.c
    @@ -796,8 +796,8 @@ static int intel_prop_read(struct sdw_bus *bus)

    /* BIOS is not giving some values correctly. So, lets override them */
    bus->prop.num_freq = 1;
    - bus->prop.freq = devm_kcalloc(bus->dev, sizeof(*bus->prop.freq),
    - bus->prop.num_freq, GFP_KERNEL);
    + bus->prop.freq = devm_kcalloc(bus->dev, bus->prop.num_freq,
    + sizeof(*bus->prop.freq), GFP_KERNEL);
    if (!bus->prop.freq)
    return -ENOMEM;

    --
    2.17.1
    \
     
     \ /
      Last update: 2019-04-11 05:18    [W:2.852 / U:0.252 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site