lkml.org 
[lkml]   [2019]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC patch 28/41] dma/debug: Simplify stracktrace retrieval
On Wed, 10 Apr 2019 22:02:01 -0500
Josh Poimboeuf <jpoimboe@redhat.com> wrote:

> > #ifdef CONFIG_STACKTRACE
> > - struct stack_trace stacktrace;
> > - unsigned long st_entries[DMA_DEBUG_STACKTRACE_ENTRIES];
> > + unsigned int st_len;
> > + unsigned long st_entries[DMA_DEBUG_STACKTRACE_ENTRIES];
>
> nit: st_entries isn't very readable. Thanks to the magic of compilers,
> the characters are free, so why not call them "stacktrace_entries" and
> "stacktrace_len".

But doesn't that slow down the time it takes to compile?

/me runs...

-- Steve

\
 
 \ /
  Last update: 2019-04-11 05:10    [W:0.043 / U:60.416 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site