lkml.org 
[lkml]   [2019]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 2/2] kernel: use sysctl shared variables for range check
On Wed, Apr 10, 2019 at 11:51 PM Kees Cook <keescook@chromium.org> wrote:
>
> On Wed, Apr 10, 2019 at 12:24 PM Matteo Croce <mcroce@redhat.com> wrote:
> >
> > On Wed, Apr 10, 2019 at 8:46 PM Kees Cook <keescook@chromium.org> wrote:
> > >
> > > On Mon, Apr 8, 2019 at 3:09 PM Matteo Croce <mcroce@redhat.com> wrote:
> > > >
> > > > Use the shared variables for range check, instead of declaring a local one
> > > > in every source file.
> > >
> > > I was expecting this to be a tree-wide change for all the cases found
> > > by patch 1's "git grep".
> > >
> >
> > Hi Kees,
> >
> > I have already the whole patch ready, but I was frightened by the
> > output of get_maintainer.pl, so I decided to split the patch into
> > small pieces and send the first one.
>
> Heh, sounds fine. Normally the big tree-wide changes go via Linus just
> before cutting rc1 (or rc2). This is "only" 31 source files, though,
> so maybe akpm wants to take these instead? Andrew, how do you feel
> about that?
>

FYI, this are the stats from my local repo, just to let you the size
of a series with all the changes in it:

$ git --no-pager log --stat --oneline linus/master
acebb1f752e9 x86: use sysctl shared variables for range check
arch/x86/entry/vdso/vdso32-setup.c | 7 ++-----
arch/x86/kernel/itmt.c | 6 ++----
2 files changed, 4 insertions(+), 9 deletions(-)
6731f419f46d s390: use sysctl shared variables for range check
arch/s390/appldata/appldata_base.c | 15 +++++----------
arch/s390/kernel/topology.c | 6 ++----
2 files changed, 7 insertions(+), 14 deletions(-)
1189495100c6 drivers: use sysctl shared variables for range check
drivers/base/firmware_loader/fallback_table.c | 11 ++++-------
drivers/gpu/drm/i915/i915_perf.c | 8 +++-----
drivers/hv/vmbus_drv.c | 6 ++----
drivers/s390/char/sclp_async.c | 7 ++-----
drivers/tty/tty_ldisc.c | 6 ++----
drivers/xen/balloon.c | 7 ++-----
6 files changed, 15 insertions(+), 30 deletions(-)
bada6ce1f240 ipc: use sysctl shared variables for range check
ipc/ipc_sysctl.c | 35 ++++++++++++++++-------------------
1 file changed, 16 insertions(+), 19 deletions(-)
1faa590d64c5 inotify: use sysctl shared variables for range check
fs/notify/inotify/inotify_user.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
ad4254677a52 security: use sysctl shared variables for range check
security/keys/sysctl.c | 26 ++++++++++++--------------
security/loadpin/loadpin.c | 6 ++----
security/yama/yama_lsm.c | 3 +--
3 files changed, 15 insertions(+), 20 deletions(-)
3d2211ab8c7c net: use sysctl shared variables for range check
net/core/neighbour.c | 20 ++++++-------
net/core/sysctl_net_core.c | 34 ++++++++++------------
net/dccp/sysctl.c | 16 +++++-----
net/ipv4/sysctl_net_ipv4.c | 58 ++++++++++++++++++-------------------
net/ipv6/addrconf.c | 6 ++--
net/ipv6/route.c | 7 ++---
net/ipv6/sysctl_net_ipv6.c | 8 ++---
net/mpls/af_mpls.c | 10 +++----
net/netfilter/ipvs/ip_vs_ctl.c | 3 +-
net/rxrpc/sysctl.c | 9 +++---
net/sctp/sysctl.c | 35 ++++++++++------------
net/sunrpc/xprtrdma/transport.c | 3 +-
12 files changed, 93 insertions(+), 116 deletions(-)
f20fd0e406ec kernel: use sysctl shared variables for range check
kernel/pid_namespace.c | 3 +-
kernel/sysctl.c | 193 ++++++++++++++++++++++-----------------------
kernel/ucount.c | 6 +-
3 files changed, 98 insertions(+), 104 deletions(-)
05fc54289d17 proc/sysctl: add shared variables for range check
fs/proc/proc_sysctl.c | 5 +++++
include/linux/sysctl.h | 4 ++++
2 files changed, 9 insertions(+)


--
Matteo Croce
per aspera ad upstream

\
 
 \ /
  Last update: 2019-04-11 00:31    [W:0.906 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site