Messages in this thread | | | Date | Wed, 10 Apr 2019 09:01:52 +0200 | From | Peter Zijlstra <> | Subject | Re: [RFC PATCH v2 12/14] x86/watchdog/hardlockup/hpet: Determine if HPET timer caused NMI |
| |
On Tue, Apr 09, 2019 at 06:19:57PM -0700, Ricardo Neri wrote: > On Tue, Apr 09, 2019 at 01:28:17PM +0200, Peter Zijlstra wrote: > > > @@ -147,6 +161,14 @@ static void set_periodic(struct hpet_hld_data *hdata) > > > */ > > > static bool is_hpet_wdt_interrupt(struct hpet_hld_data *hdata) > > > { > > > + if (smp_processor_id() == hdata->handling_cpu) { > > > + unsigned long tsc_curr; > > > > TSC is u64 > > In x86_64, isn't u64 an unsigned long? Do you mean to consider the > 32-bit case?
Unless none of this code is available for x86_32, you pretty much have to consider 32bit.
But even then, using u64 for 64bit values is the right thing.
| |